Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with settings factory #74

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

maximehuran
Copy link
Member

@maximehuran maximehuran commented Aug 29, 2024

Correct error

Cannot autowire service "MonsieurBiz\SyliusSettingsPlugin\Factory\SettingFactory": argument "$class  
  Name" of method "__construct()" is type-hinted "string", you should configure its value explicitly.

And fix PHP CS

@madamebiz madamebiz added the quick win Easy to pick, everybody will be happy. label Aug 29, 2024
@clairecoloma
Copy link

This error:

 Cannot autowire service "MonsieurBiz\SyliusSettingsPlugin\Factory\SettingFactory": argument "$class  
  Name" of method "__construct()" is type-hinted "string", you should configure its value explicitly.

? 😄

@maximehuran maximehuran force-pushed the feature/factory-issue branch from 5659ba5 to 099d8c3 Compare August 30, 2024 07:52
@maximehuran maximehuran requested a review from lanfisis August 30, 2024 07:53
@madamebiz madamebiz added the Status: needs review Needs review label Aug 30, 2024
@lanfisis lanfisis merged commit f2cf7ee into monsieurbiz:master Aug 30, 2024
10 checks passed
@maximehuran maximehuran deleted the feature/factory-issue branch September 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick win Easy to pick, everybody will be happy. Status: needs review Needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants